app.js ➔ multiFileDrop - Code Metrics - Inspection of "Merge pull request #67 from butcherman/dev4" - butcherman/Tech_Bench - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 836696...7e7f2a )

by Ron

created 2019-04-16 23:57 UTC

app.js ➔ multiFileDrop B

↳ Parent: resources/assets/js/app.js

Complexity

Conditions	1
Paths	1

Size

Total Lines	71
Code Lines	42

Duplication

Lines	71
Ratio	100 %

Importance

Changes

Metric	Value
cc	1
eloc	42
nc	1
nop	1
dl	71
loc	71
rs	8.872
c	0
b	0
f	0

1 Function

Rating	Name	Duplication	Size	Complexity
A	app.js ➔ ... ➔ $(ꞌ#dropzone-boxꞌ).dropzone.init	54	54	1

How to fix Long Method

/** global: maxUpload */
//  Third Party Libraries
require('./bootstrap');
require('jquery-easing');
require('datatables.net-bs4');
require('dropzone');
require('select2');
require('fastselect');
//require('clipboard');

$(document).ready(function()
{
    //  Enable any tooltips on the page
    initTooltip();
});

//  Initialize any tooltips on the page
function initTooltip()
{
    $('[data-tooltip="tooltip"]').tooltip();
}

/////////////////////////// Drag and Drop/File Upload Functions ////////////////////////////////////
//  Initialize drag and drop for only one file
function fileDrop(form)

{
    //  Initialize Drag and Drop            
    var drop = $('#dropzone-box').dropzone(

    {
        url: form.attr('action'),
        autoProcessQueue: false,
        parallelUploads: 1,
        maxFiles: 1,
        maxFilesize: maxUpload,
        addRemoveLinks: true,
        chunking: true,
        chunkSize: 1000000,
        parallelChunkUploads: false,
        method: "POST",
        init: function()
        {
            var myDrop = this;
            form.on('submit', function(e, formData)

            {
                e.preventDefault();
                if(myDrop.getQueuedFiles().length > 0)
                {
                    myDrop.processQueue();
                    $('#forProgressBar').show();
                    $('.submit-button').attr('disabled', true);
                }
                else
                {
                    $.post(form.attr('action'), form.serialize(), function(data)
                    {
                        uploadComplete(data);
                    });
                }
            });
            this.on('sending', function(file, xhr, formData)
            {
                var formArray = form.serializeArray();
                $.each(formArray, function()
                {
                    formData.append(this.name, this.value);
                }); 
            });
            this.on('uploadprogress', function(progress)
            {
                var prog = Math.round(progress.upload.progress);
                    
                if(prog != 100)
                {
                    $("#progressBar").css("width", prog+"%");
                    $("#progressStatus").text(prog+"%");
                }
//                $("#progressBar").css("width", Math.round(progress.upload.progress)+"%");
//                $("#progressStatus").text(Math.round(progress.upload.progress)+"%");
            });
            this.on('reset', function()
            {
                $('#form-errors').addClass('d-none');
            });
            this.on('success', function(files, response)
            {
                console.log(response);

                uploadComplete(response);
            });
            this.on('errormultiple', function(file, response)
            {
                uploadFailed(response);
            });
        }
    });
}

//  Initialize drag and drop for multiple file uploads
function multiFileDrop(form)

{
    //  Initialize Drag and Drop            
    var drop = $('#dropzone-box').dropzone(

    {
        url: form.attr('action'),
        autoProcessQueue: false,
        parallelUploads: 1,
        maxFiles: 1,
        maxFilesize: maxUpload,
        addRemoveLinks: true,
        chunking: true,
        chunkSize: 1000000,
        parallelChunkUploads: false,
        method: "POST",
        init: function()
        {
            var myDrop = this;
            form.on('submit', function(e, formData)

            {
                e.preventDefault();
                if(myDrop.getQueuedFiles().length > 0)
                {
                    myDrop.processQueue();
                    $('#forProgressBar').show();
                    $('.submit-button').attr('disabled', true);
                }
                else
                {
                    $.post(form.attr('action'), form.serialize(), function(data)
                    {
                        uploadComplete(data);
                    });
                }
            });
            this.on('sending', function(file, xhr, formData)
            {
                var formArray = form.serializeArray();
                $.each(formArray, function()
                {
                    formData.append(this.name, this.value);
                }); 
            });
            this.on('uploadprogress', function(progress)
            {
                var prog = Math.round(progress.upload.progress);
                    
                if(prog != 100)
                {
                    $("#progressBar").css("width", prog+"%");
                    $("#progressStatus").text(prog+"%");
                }
//                $("#progressBar").css("width", Math.round(progress.upload.progress)+"%");
//                $("#progressStatus").text(Math.round(progress.upload.progress)+"%");
            });
            this.on('reset', function()
            {
                $('#form-errors').addClass('d-none');
            });
            this.on('success', function(files, response)
            {
                console.log(response);

                uploadComplete(response);
            });
            this.on('errormultiple', function(file, response)
            {
                uploadFailed(response);
            });
        }
    });
}

//  Reset the progress bar and drag and drop box
function resetProgressBar()
{
    $('#dragndrop-notice').text('Or Drag Files Here');
    $('#progressBar').css('width', '0%').attr('aria-valuenow', 0);
    $('#progressStatus').text('');
    $('#forProgressBar').hide();
}

//  Reset the Edit Modal to its default state
function resetEditModal()
{
    $('#edit-modal').modal('hide');
    $('#edit-modal').find('.modal-title').text('');
    $('#edit-modal').find('.modal-body').text('');
}

//////////////////////////////////////////////////////////////////////////////////////////

//  Make the functions in this file globally accessable
window.resetProgressBar = resetProgressBar;
window.resetEditModal   = resetEditModal;
window.fileDrop         = fileDrop;
window.multiFileDrop    = multiFileDrop;


1		/** global: maxUpload */
2		// Third Party Libraries
3		require('./bootstrap');
4		require('jquery-easing');
5		require('datatables.net-bs4');
6		require('dropzone');
7		require('select2');
8		require('fastselect');
9		//require('clipboard');
10
11		$(document).ready(function()
12		{
13		// Enable any tooltips on the page
14		initTooltip();
15		});
16
17		// Initialize any tooltips on the page
18		function initTooltip()
19		{
20		$('[data-tooltip="tooltip"]').tooltip();
21		}
22
23		/////////////////////////// Drag and Drop/File Upload Functions ////////////////////////////////////
24		// Initialize drag and drop for only one file
25	View Code Duplication	function fileDrop(form)
		0 ignored issues – show Duplication introduced 2019-04-16 05:00 UTC by Report Bug Copy Issue Report This code seems to be duplicated in your project. Loading history...
26		{
27		// Initialize Drag and Drop
28		var drop = $('#dropzone-box').dropzone(
		0 ignored issues – show Unused Code introduced 2018-12-20 17:13 UTC by Report Bug Copy Issue Report The variable `drop` seems to be never used. Consider removing it. Loading history...
29		{
30		url: form.attr('action'),
31		autoProcessQueue: false,
32		parallelUploads: 1,
33		maxFiles: 1,
34		maxFilesize: maxUpload,
35		addRemoveLinks: true,
36		chunking: true,
37		chunkSize: 1000000,
38		parallelChunkUploads: false,
39		method: "POST",
40		init: function()
41		{
42		var myDrop = this;
43		form.on('submit', function(e, formData)
		0 ignored issues – show Unused Code introduced 2018-12-20 17:13 UTC by Report Bug Copy Issue Report The parameter `formData` is not used and could be removed. This check looks for parameters in functions that are not used in the function body and are not followed by other parameters which are used inside the function. Loading history...
44		{
45		e.preventDefault();
46		if(myDrop.getQueuedFiles().length > 0)
47		{
48		myDrop.processQueue();
49		$('#forProgressBar').show();
50		$('.submit-button').attr('disabled', true);
51		}
52		else
53		{
54		$.post(form.attr('action'), form.serialize(), function(data)
55		{
56		uploadComplete(data);
57		});
58		}
59		});
60		this.on('sending', function(file, xhr, formData)
61		{
62		var formArray = form.serializeArray();
63		$.each(formArray, function()
64		{
65		formData.append(this.name, this.value);
66		});
67		});
68		this.on('uploadprogress', function(progress)
69		{
70		var prog = Math.round(progress.upload.progress);
71
72		if(prog != 100)
73		{
74		$("#progressBar").css("width", prog+"%");
75		$("#progressStatus").text(prog+"%");
76		}
77		// $("#progressBar").css("width", Math.round(progress.upload.progress)+"%");
78		// $("#progressStatus").text(Math.round(progress.upload.progress)+"%");
79		});
80		this.on('reset', function()
81		{
82		$('#form-errors').addClass('d-none');
83		});
84		this.on('success', function(files, response)
85		{
86		console.log(response);
		0 ignored issues – show Debugging Code introduced 2019-04-16 05:00 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history...
87		uploadComplete(response);
88		});
89		this.on('errormultiple', function(file, response)
90		{
91		uploadFailed(response);
92		});
93		}
94		});
95		}
96
97		// Initialize drag and drop for multiple file uploads
98	View Code Duplication	function multiFileDrop(form)
		0 ignored issues – show Duplication introduced 2019-04-16 05:00 UTC by Report Bug Copy Issue Report This code seems to be duplicated in your project. Loading history...
99		{
100		// Initialize Drag and Drop
101		var drop = $('#dropzone-box').dropzone(
		0 ignored issues – show Unused Code introduced 2018-12-20 17:13 UTC by Report Bug Copy Issue Report The variable `drop` seems to be never used. Consider removing it. Loading history...
102		{
103		url: form.attr('action'),
104		autoProcessQueue: false,
105		parallelUploads: 1,
106		maxFiles: 1,
107		maxFilesize: maxUpload,
108		addRemoveLinks: true,
109		chunking: true,
110		chunkSize: 1000000,
111		parallelChunkUploads: false,
112		method: "POST",
113		init: function()
114		{
115		var myDrop = this;
116		form.on('submit', function(e, formData)
		0 ignored issues – show Unused Code introduced 2018-12-20 17:13 UTC by Report Bug Copy Issue Report The parameter `formData` is not used and could be removed. This check looks for parameters in functions that are not used in the function body and are not followed by other parameters which are used inside the function. Loading history...
117		{
118		e.preventDefault();
119		if(myDrop.getQueuedFiles().length > 0)
120		{
121		myDrop.processQueue();
122		$('#forProgressBar').show();
123		$('.submit-button').attr('disabled', true);
124		}
125		else
126		{
127		$.post(form.attr('action'), form.serialize(), function(data)
128		{
129		uploadComplete(data);
130		});
131		}
132		});
133		this.on('sending', function(file, xhr, formData)
134		{
135		var formArray = form.serializeArray();
136		$.each(formArray, function()
137		{
138		formData.append(this.name, this.value);
139		});
140		});
141		this.on('uploadprogress', function(progress)
142		{
143		var prog = Math.round(progress.upload.progress);
144
145		if(prog != 100)
146		{
147		$("#progressBar").css("width", prog+"%");
148		$("#progressStatus").text(prog+"%");
149		}
150		// $("#progressBar").css("width", Math.round(progress.upload.progress)+"%");
151		// $("#progressStatus").text(Math.round(progress.upload.progress)+"%");
152		});
153		this.on('reset', function()
154		{
155		$('#form-errors').addClass('d-none');
156		});
157		this.on('success', function(files, response)
158		{
159		console.log(response);
		0 ignored issues – show Debugging Code introduced 2019-04-16 05:00 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history...
160		uploadComplete(response);
161		});
162		this.on('errormultiple', function(file, response)
163		{
164		uploadFailed(response);
165		});
166		}
167		});
168		}
169
170		// Reset the progress bar and drag and drop box
171		function resetProgressBar()
172		{
173		$('#dragndrop-notice').text('Or Drag Files Here');
174		$('#progressBar').css('width', '0%').attr('aria-valuenow', 0);
175		$('#progressStatus').text('');
176		$('#forProgressBar').hide();
177		}
178
179		// Reset the Edit Modal to its default state
180		function resetEditModal()
181		{
182		$('#edit-modal').modal('hide');
183		$('#edit-modal').find('.modal-title').text('');
184		$('#edit-modal').find('.modal-body').text('');
185		}
186
187		//////////////////////////////////////////////////////////////////////////////////////////
188
189		// Make the functions in this file globally accessable
190		window.resetProgressBar = resetProgressBar;
191		window.resetEditModal = resetEditModal;
192		window.fileDrop = fileDrop;
193		window.multiFileDrop = multiFileDrop;
194

butcherman / Tech_Bench

Push — master ( 836696...7e7f2a )

app.js ➔ multiFileDrop B

Complexity

Size

Duplication

Importance

1 Function

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like